-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle transfer credits #536
base: main
Are you sure you want to change the base?
Conversation
…to restyle-transfer-credits
…to restyle-transfer-credits merge updated upstream from main
…to restyle-transfer-credits pull changes from main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, just a couple things
- See above comment about styling
- You opened the PR but didn't set two reviewers. Make sure to set me as one reviewer and one other individual contributor as a second reviewer.
…to restyle-transfer-credits
Looks a bit better now, but just one more thing to check – is the input font size at least 16px? When I tap the field on iOS, it zooms the entire page, which usually means that the font size is less than that size |
The input font size seems to be 14px. However, it's the same with the original Transfer Credits modal, as well as Edit Roadmap, New Roadmap, Add Year, etc. According to the inspector in Firefox and Chrome, all these input boxes seem to have I tested the inputs of existing modals on iOS 18 (with appetize.io), and even the main course catalog search bar, and they all seem to have this zoom behavior. I think this makes sense and is expected, to let users see the input more clearly? But if it's a problem, maybe we should make a new issue for it, since it affects much more than just the Transfer Credits restyle? EDIT: just checked and found that there's already an issue for this (see #457) |
Restyle the Transfer Credits modal (under Roadmap page)
Description
ppc-modal
(ex. theedit year
modal)p
smaller when inside atransfer-modal
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #517